Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for java version 23 #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix for java version 23 #7

wants to merge 4 commits into from

Conversation

KesSaft
Copy link

@KesSaft KesSaft commented Jan 11, 2025

No description provided.

janbnz
janbnz reviewed Jan 17, 2025
View reviewed changes
Copy link
Owner

@janbnz janbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to update to Java 23 but what is the point of disabling the metrics and adding a main class called "com.beginsecure.App" which clearly does not exist?
You also added .idea

@KesSaft
Copy link
Author

KesSaft commented Jan 17, 2025

The metrics didn't work for me so I just comentend them out. The .idea folder I forgot to add to .gitignore and the I forgot the change the class. I guess because it just worked :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbnz janbnz janbnz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KesSaft @janbnz